Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][Graph] Improve unsupported node update error #17637

Open
wants to merge 1 commit into
base: sycl
Choose a base branch
from

Conversation

Bensuo
Copy link
Contributor

@Bensuo Bensuo commented Mar 25, 2025

  • Include node type in error message
  • Fix unit test triggering topology error instead of unsupported node type error

Example output of new error:

terminate called after throwing an instance of 'sycl::_V1::exception'
  what():  node_type::memfill nodes are not supported for update. Only kernel, host_task, barrier and empty nodes are supported.

@Bensuo Bensuo requested a review from a team as a code owner March 25, 2025 13:30
@Bensuo Bensuo requested a review from reble March 25, 2025 13:30
@Bensuo Bensuo temporarily deployed to WindowsCILock March 25, 2025 13:31 — with GitHub Actions Inactive
@Bensuo Bensuo temporarily deployed to WindowsCILock March 25, 2025 14:01 — with GitHub Actions Inactive
@Bensuo Bensuo temporarily deployed to WindowsCILock March 25, 2025 14:01 — with GitHub Actions Inactive
- Include node type in error message
- Fix unit test triggering topology error instead of unsupported node type error
@EwanC EwanC force-pushed the ben/unsupported-node-error branch from 361df20 to 4b1e561 Compare March 26, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant