[SYCL][Graph] Fix issue when updating HostTasks with whole graph update #17645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiomestre
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
fabiomestre
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
fabiomestre
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
fabiomestre
force-pushed
the
fabio/fix_host_task_whole_graph_update
branch
from
030bb18 to
2d8d5e8
Compare
fabiomestre
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
fabiomestre
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
fabiomestre
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
fabiomestre
force-pushed
the
fabio/fix_host_task_whole_graph_update
branch
from
2d8d5e8 to
1a70572
Compare
fabiomestre
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
fabiomestre
changed the title
fabiomestre
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
fabiomestre
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
When updating a HostTask using whole graph update, we rely on the Sycl Scheduler to execute the HostTask and all its dependencies. The Scheduler executes this work asynchronously using a separate thread. Since exec_graph.update() was non-blocking, this was causing issues, where the user code could, for example, free resources, before the update() command (which is a dependent on the HostTask completion) could execute. This commit fixes this issue by making exec_graph.update() blocking when host_tasks are used.
fabiomestre
force-pushed
the
fabio/fix_host_task_whole_graph_update
branch
from
1a70572 to
95a6582
Compare
fabiomestre
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
fabiomestre
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
fabiomestre
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
…hole_graph_update
EwanC
changed the title
|
@intel/llvm-gatekeepers This is ready to merge thanks |
ggojska
pushed a commit
to ggojska/llvm
that referenced
this pull request
Apr 7, 2025
…te (intel#17645) When updating a HostTask using whole graph update, we rely on the Sycl Scheduler to execute the HostTask and all its dependencies. The Scheduler executes this work asynchronously using a separate thread. Since exec_graph.update() was non-blocking, this was causing issues, where the user code could, for example, free resources, before the update() command (which is a dependent on the HostTask completion) could execute. This commit fixes this issue by making exec_graph.update() blocking when host_tasks are used. Co-authored-by: Ewan Crawford <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When updating a HostTask using whole graph update, we rely
on the Sycl Scheduler to execute the HostTask and all its
dependencies. The Scheduler executes this work asynchronously
using a separate thread. Since exec_graph.update() was non-blocking,
this was causing issues, where the user code could, for example,
free resources, before the update() command (which is a dependent on the
HostTask completion) could execute.
This commit fixes this issue by making exec_graph.update() blocking
when host_tasks are used.