[NFCI][SYCL] Make sure platform_impl could only be owned by GlobalHandler
#18141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Handler` This is a pre-requisite to eliminate `PlatformImplPtr` and use `platform_impl` by raw pointer/reference throught the SYCL RT library.
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
I think I'll need something like https://stackoverflow.com/questions/657155/how-to-enable-shared-from-this-of-both-parent-and-derived at a later point (at least before the next major release), but that could be ignored for now. |
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
vinser52
reviewed
Apr 23, 2025
vinser52
approved these changes
Apr 24, 2025
againull
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pre-requisite to eliminate
PlatformImplPtrand useplatform_implby raw pointer/reference throught the SYCL RT library.