Skip to content

[UR] Add dockers to UR workflow #18162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: sycl
Choose a base branch
from
Open

[UR] Add dockers to UR workflow #18162

wants to merge 3 commits into from
+177 −97

Conversation

rbanka1
Copy link
Contributor

@rbanka1 rbanka1 commented Apr 23, 2025 •
edited by ayylol
Loading

@rbanka1 rbanka1 requested a review from a team as a code owner April 23, 2025 16:11
@sarnex
Copy link
Contributor

sarnex commented Apr 23, 2025

Is this ready for review?

@lukaszstolarczuk lukaszstolarczuk changed the title [UR] add UR docker [UR] Add dockers to UR workflow Apr 24, 2025
@lukaszstolarczuk
Copy link
Contributor

Is this ready for review?

I think this is the "almost ready" version 😉

lukaszstolarczuk
lukaszstolarczuk requested changes Apr 24, 2025
View reviewed changes
.github/workflows/ur-precommit.yml Outdated
@@ -5,6 +5,9 @@ name: Unified Runtime Pre Commit

# Note: the trigger is copy-pasted from sycl-linux-precommit.yml - probably to be fine-tuned.
on:
push:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this to be removed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

.github/workflows/ur-precommit.yml Outdated
- name: Build
run: cmake --build ${{github.workspace}}/build -j $(sysctl -n hw.logicalcpu)
# - name: Build
# run: cmake --build ${{github.workspace}}/build -j $(sysctl -n hw.logicalcpu)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing EOF

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

.github/workflows/ur-build-hw.yml Outdated

- name: Get information about platform
if: ${{ always() }}
run: ${{github.workspace}}/unified-runtime/.github/scripts/get_system_info.sh
run: ./unified-runtime/.github/scripts/get_system_info.sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing EOF

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

.github/workflows/ur-build-hw.yml Outdated

- name: Test adapter specific
env:
ZE_ENABLE_LOADER_DEBUG_TRACE: 1
run: ctest -C ${{matrix.build_type}} --test-dir ${{github.workspace}}/build --output-on-failure -L "adapter-specific" -E "memcheck" --timeout 600 -VV
ZE_DEBUG: 1
run: ctest -C ${{matrix.build_type}} --test-dir build --output-on-failure -L "adapter-specific" -E "memcheck" --timeout 600
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed -VV - is this on purpose?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

restored

.github/workflows/ur-build-hw.yml
run: |
python3 -m venv .venv
. .venv/bin/activate
echo "$PATH" >> $GITHUB_PATH
echo "${PWD}/.venv/bin" >> $GITHUB_PATH
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when activate is called, I believe the PATH var is updated, this is why echo "$PATH" >> $GITHUB_PATH should work...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left it untouched because after changing it I can't find 'lit'

.github/workflows/ur-build-hw.yml
@@ -94,28 +113,42 @@ jobs:
- name: Checkout LLVM
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1

# Latest distros do not allow global pip installation
- name: Set up Python 3.10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you really need it, please add a comment why

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

.github/workflows/ur-build-hw.yml Outdated
# Latest distros do not allow global pip installation
- name: Set up Python 3.10
if: ${{ inputs.docker_image == 'ghcr.io/intel/llvm/ubuntu2404_intel_drivers:alldeps' }}
uses: actions/setup-python@v5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls use syntax as in other actions ...@<sha> # vXXX

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

.github/workflows/ur-build-hw.yml Outdated

env:
UR_LOG_CUDA: "level:error;flush:error"
UR_LOG_HIP: "level:error;flush:error"
UR_LOG_LEVEL_ZERO: "level:error;flush:error"
UR_LOG_NATIVE_CPU: "level:error;flush:error"
UR_LOG_OPENCL: "level:error;flush:error"
CURRENT_DIR: $(pwd)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be removed...?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

@lukaszstolarczuk lukaszstolarczuk mentioned this pull request Apr 24, 2025
Draft
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukaszstolarczuk lukaszstolarczuk lukaszstolarczuk requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rbanka1 @sarnex @lukaszstolarczuk