[UR][L0 v2][draft] Port USM alloc to adapter v2 #18179
Conversation
| @@ -348,19 +348,21 @@ ur_result_t urEnqueueUSMDeviceAllocExp( | |||
| uint32_t numEventsInWaitList, const ur_event_handle_t *phEventWaitList, | |||
There was a problem hiding this comment.
This file is auto-generated. If you want to modify it you need to change scripts/templates/queue_api.cpp.mako (same is true for the corresponding .hpp file)
There was a problem hiding this comment.
But I don't think you need to actually modify it. As far as I understand you wanted to add ur_queue_handle_t param so that you can pass it to EnqueuedPool functions (like getBestFit, etc.). However, if I'm not mistaken, the queue is only used as an identifier by the EnqueuedPool implementation. This means that you can just do something like this in queue_immediate_in_order.cpp:
...
getBestFit(size, alignment, reinterpret_cast<ur_queue_handle_t>(this));
If the EnqueuedPool actually needs to have valid queue handle, then I think it would be better to rewrite EnqueuedPool (which you might need to do anyway, as it has some logic for handling events that is legacy-specific).
|
|
||
| auto device = (type == UR_USM_TYPE_HOST) ? nullptr : hDevice; | ||
|
|
||
| std::vector<ur_event_handle_t> extendedWaitList; |
There was a problem hiding this comment.
You don;t need to create a temporary vector here. commandListManger has getWaitListView function that you should use here (it also accepts an optional extra wait event). You just call: getWaitListView(commandListLocked, phEventWaitList, numEventsInWaitList, originAllocEvent);
| return Ret; | ||
| } | ||
| } else { | ||
| *ppMem = std::get<0>(*asyncAlloc); |
There was a problem hiding this comment.
nit: std::tie(*ppMem, originAllocEvent) = *asyncAlloc;
| const ur_exp_async_usm_alloc_properties_t *pProperties, | ||
| uint32_t numEventsInWaitList, const ur_event_handle_t *phEventWaitList, | ||
| void **ppMem, ur_event_handle_t *phEvent) { | ||
| return enqueueUSMAllocHelper(hQueue, pPool, size, pProperties, |
There was a problem hiding this comment.
Please add TRACK_SCOPE_LATENCY("ur_queue_immediate_in_order_t::enqueueUSMHostAllocExp"); at the beginning of this function (and other function you implement in this patch).
This PR ports USM alloc enqueue API introduced to L0 adapter in #17112 to L0 adapter v2.