[SYCL][E2E] Fix fallback code path from #18627 #18753
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the fallback code path taken when `clang --print-prog-name` fails. The fallback code in 871e907 ([SYCL][E2E] Better handle the Intel Compiler in standalone build (NFC) (intel#18627)) is broken, it uses the wrong variable name (`tool` instead of `name`) and refers to the unqualified `CalledProcessError` without importing it.
|
@intel/llvm-gatekeepers please merge :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the fallback code path taken when
clang --print-prog-namefails. The fallback code in871e907 ([SYCL][E2E] Better handle the Intel Compiler in standalone build (NFC) (#18627)) is broken, it uses the wrong variable name (
toolinstead ofname) and refers to the unqualifiedCalledProcessErrorwithout importing it.