Skip to content

[SYCL][UR][l0v2] Use counter-based evets #20473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mateuszpn wants to merge 17 commits into from
Closed

[SYCL][UR][l0v2] Use counter-based evets #20473

mateuszpn wants to merge 17 commits into from

Conversation

@mateuszpn
Copy link
Contributor

@mateuszpn mateuszpn commented Oct 27, 2025

No description provided.

@mateuszpn mateuszpn requested review from a team as code owners October 27, 2025 08:06
@mateuszpn
bump l0 version
7e84479 
Signed-off-by: Mateusz P. Nowak <[email protected]>
@mateuszpn mateuszpn marked this pull request as draft October 27, 2025 14:25
@mateuszpn
Copy link
Contributor Author

mateuszpn commented Nov 27, 2025

@intel/unified-runtime-reviewers-level-zero This is kind invitation for the review

kswiecicki
kswiecicki reviewed Dec 1, 2025
View reviewed changes
unified-runtime/source/adapters/level_zero/v2/context.cpp
std::ignore = platform;

// TODO: just use per-context id?
return std::make_unique<v2::provider_normal>(
Copy link
Contributor

@kswiecicki kswiecicki Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are always creating eventPoolCacheRegular with counter based events (flags param always contains EVENT_FLAGS_COUNTER flag) too. Shouldn't we also enable v2::provider_counter here?
@pbalcer what do you think?

Copy link
Contributor

@pbalcer pbalcer Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, we should.

pbalcer
pbalcer reviewed Dec 2, 2025
View reviewed changes
unified-runtime/source/adapters/level_zero/v2/event_provider_counter.cpp
Comment on lines 31 to 33
ZE2UR_CALL_THROWS(zeDriverGetExtensionFunctionAddress,
(platform->ZeDriver, "zexCounterBasedEventCreate",
(platform->ZeDriver, "zexCounterBasedEventCreate2",
(void **)&this->eventCreateFunc));
Copy link
Contributor

@pbalcer pbalcer Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the earlier driver version this function is available in?
This is a key functionality, I think we need to implement a fallback. I suggest creating a function that creates a provider, first by trying to create a "provider counter", and then "provider normal" if that fails.

@pbalcer
Copy link
Contributor

pbalcer commented Dec 2, 2025

Superseded by #20788

@mateuszpn mateuszpn closed this Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pbalcer pbalcer pbalcer left review comments

@kswiecicki kswiecicki kswiecicki left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mateuszpn @pbalcer @kswiecicki @igchor @luszczewskakasia1