Add CPU counter benchmark #20978
Open
Add CPU counter benchmark #20978
+264
−173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luszczewskakasia1
force-pushed
the
count-bench
branch
10 times, most recently
from
8901898 to
ccad86b
Compare
PatKamin
reviewed
Dec 31, 2025
| ret.append(f"{k} {v}") | ||
| ret.sort() | ||
| return self._bench_name + " " + ", ".join(ret) | ||
| return self._bench_name + " " + ", ".join(ret) + self._cpu_count_str() |
Contributor
There was a problem hiding this comment.
explicit_group and display_name have to include this string as well.
Contributor
|
Drafted until cpu count support is merged in Compute Benchmarks repo |
luszczewskakasia1
force-pushed
the
count-bench
branch
5 times, most recently
from
fc5fea3 to
2f93b79
Compare
Signed-off-by: luszczewskakasia1 <[email protected]>
| PROFILERS.TIMER, | ||
| **{**kwargs, "warmupIterations": 1}, | ||
| ) | ||
| def createTorchSlmSizeBench(variant_name: str, **kwargs): |
Contributor
There was a problem hiding this comment.
bad rebase? we now have 2 createTorchSlmSizeBench funcs
| "KernelSubmitSingleQueue Int32Large", | ||
| {"pytorch", "L0"}, | ||
| ) | ||
| self._checkCase( |
Contributor
There was a problem hiding this comment.
I believe we don't need so many new Test Cases, we can just add 1 or 2 new test, and the rest we can randomly update (some existing TCs can have just added the "CPU count").
Contributor
|
change in Compute Benchmarks already merged, you may continue work here now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.