[UR][L0v2] Remove checkP2PAccess() from appendUSMMemcpy()#22130
Open
ldorau wants to merge 1 commit into
Open
Conversation
ldorau
changed the title
The checkP2PAccess() helper in command_list_manager.cpp rejected device-to-device USM memcpy operations between devices without P2P access enabled, returning UR_RESULT_ERROR_INVALID_OPERATION. Remove the check: P2P access controls memory residency (pinning), not hardware data transfer. Level Zero can move data between devices via the interconnect regardless of residency state, so blocking the copy at the UR level is unnecessary and overly restrictive. Update tests to match the new behavior. Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The checkP2PAccess() helper in command_list_manager.cpp rejected
device-to-device USM memcpy operations between devices without P2P
access enabled, returning UR_RESULT_ERROR_INVALID_OPERATION.
Remove the check: P2P access controls memory residency (pinning), not
hardware data transfer. Level Zero can move data between devices via the
interconnect regardless of residency state, so blocking the copy at the
UR level is unnecessary and overly restrictive.
Update tests to match the new behavior.