[SYCL][E2E] Re-enable WorkGroupMemory/basic_usage.cpp on HIP#22726
Open
zjin-lcf wants to merge 1 commit into
Open
[SYCL][E2E] Re-enable WorkGroupMemory/basic_usage.cpp on HIP#22726zjin-lcf wants to merge 1 commit into
zjin-lcf wants to merge 1 commit into
Conversation
This test was marked UNSUPPORTED on HIP due to the flaky-CI hang tracked in intel#17339. The underlying failure mode on current ROCm is a compiler crash in GlobalOffsetPass ("Calling a function with a bad signature!") triggered by in-kernel asserts combined with get_global_id usage, which is fixed by intel#22677. With that fix, the test compiles (asserts enabled) and passes on gfx942 (MI300A), so remove the UNSUPPORTED: hip marker. Depends on intel#22677. Closes intel#17339. Co-authored-by: Cursor <cursoragent@cursor.com>
KseniyaTikhomirova
approved these changes
Jul 23, 2026
KseniyaTikhomirova
left a comment
KseniyaTikhomirova
left a comment
Contributor
There was a problem hiding this comment.
LGTM, can be merged once dependent fix is merged, I see it has been already approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test was marked UNSUPPORTED on HIP due to the flaky-CI hang tracked in #17339. The underlying failure mode on current ROCm is a compiler crash in GlobalOffsetPass ("Calling a function with a bad signature!") triggered by in-kernel asserts combined with get_global_id usage, which is fixed by #22677.
With that fix, the test compiles (asserts enabled) and passes on gfx942 (MI300A), so remove the UNSUPPORTED: hip marker.
Depends on #22677.