Skip to content

Conversation

@XuehaoSun
Copy link
Contributor

@XuehaoSun XuehaoSun commented Dec 12, 2025

User description

Type of Change

feature or bug fix or documentation or validation or others
API changed or not

Description

detail description

Expected Behavior & Potential Risk

the expected behavior that triggered by this PR

How has this PR been tested?

how to reproduce the test (including hardware information)

Dependency Change?

any library dependency introduced or removed


PR Type

Enhancement


Description

  • Restrict peft version to 0.17.0 in requirements

Diagram Walkthrough

flowchart LR
  A["Update requirements.txt"] -- "Restrict peft version" --> B["peft <= 0.17.0"]
Loading

File Walkthrough

Relevant files
Configuration changes
requirements.txt
Restrict `peft` version                                                                   

examples/pytorch/nlp/huggingface_models/language-modeling/quantization/smooth_quant/requirements.txt

  • Updated peft version to <= 0.17.0
+1/-1     
requirements.txt
Restrict `peft` version                                                                   

examples/pytorch/nlp/huggingface_models/language-modeling/quantization/static_quant/ipex/requirements.txt

  • Updated peft version to <= 0.17.0
+1/-1     

Signed-off-by: Sun, Xuehao <[email protected]>
@PRAgent4INC
Copy link
Collaborator

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Version Constraint

The version constraint for peft is set to <= 0.17.0, which allows any version up to and including 0.17.0. Ensure that this is the intended behavior and that all versions up to 0.17.0 are compatible with the rest of the project.

peft <= 0.17.0
Version Constraint

The version constraint for peft is set to <= 0.17.0, which allows any version up to and including 0.17.0. Ensure that this is the intended behavior and that all versions up to 0.17.0 are compatible with the rest of the project.

peft <= 0.17.0

@PRAgent4INC
Copy link
Collaborator

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
General
Verify dependency compatibility

Ensure that the specified version of peft is compatible with other dependencies.

examples/pytorch/nlp/huggingface_models/language-modeling/quantization/smooth_quant/requirements.txt [12]

+peft <= 0.17.0
 
-
Suggestion importance[1-10]: 5

__

Why: The suggestion asks to verify compatibility, which is important but does not provide a direct code improvement.

Low

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants