Skip to content

Conversation

@RUIJIEZHONG66166
Copy link
Contributor

@RUIJIEZHONG66166 RUIJIEZHONG66166 commented Apr 28, 2025

@RUIJIEZHONG66166 RUIJIEZHONG66166 force-pushed the ruijie/add_op_regression_check branch 2 times, most recently from cafd374 to b88451a Compare May 8, 2025 02:56
@RUIJIEZHONG66166 RUIJIEZHONG66166 force-pushed the ruijie/add_op_regression_check branch 3 times, most recently from 79d5b40 to 8a15500 Compare May 28, 2025 05:41
@RUIJIEZHONG66166
Copy link
Contributor Author

RUIJIEZHONG66166 commented May 30, 2025

Save baseline artifact number into a github issue: #1689.
Ondemand test action job is https://github.com/intel/torch-xpu-ops/actions/runs/15337311965 (The regression check function passed)
Previously artifact number is:
image
After ondemand test finished, it changed to the ondemand action job number, which means the new baseline is updated and later test will use it:
image

@RUIJIEZHONG66166 RUIJIEZHONG66166 force-pushed the ruijie/add_op_regression_check branch from b6a188b to e92e12b Compare June 3, 2025 01:06
@RUIJIEZHONG66166 RUIJIEZHONG66166 requested review from chuanqi129 and removed request for chuanqi129 June 4, 2025 09:48
@RUIJIEZHONG66166 RUIJIEZHONG66166 requested review from chuanqi129 and removed request for chuanqi129 July 7, 2025 09:39
@RUIJIEZHONG66166
Copy link
Contributor Author

@chuanqi129 Hello, could you please help review this op regression check PR? Thanks~

@RUIJIEZHONG66166 RUIJIEZHONG66166 requested review from chuanqi129 and removed request for chuanqi129 July 11, 2025 05:41
Copy link
Contributor

@chuanqi129 chuanqi129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM. Is the on-demand test demo https://github.com/intel/torch-xpu-ops/actions/runs/15337311965 still available? Do we need to rerun a new demo?
Base on the report of current demo, give below comments:

  • The regression and improvement table sort with ratio -> case name -> op name -> dt, if possible
  • I saw there are some 99% drop cases in the regression table, are those real issue? Similar for improvement table, there are some >>100% improvement.
  • Current table has too many column, can we concat some op config in one column or other better format
  • I saw the tables are duplicate in the summary, please double check it

@RUIJIEZHONG66166 RUIJIEZHONG66166 added this pull request to the merge queue Jul 11, 2025
Merged via the queue into main with commit ae3022f Jul 11, 2025
13 of 14 checks passed
@RUIJIEZHONG66166 RUIJIEZHONG66166 deleted the ruijie/add_op_regression_check branch July 11, 2025 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants