Avoid Incorrect Boolean to Size_t Conversion #1657
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xytintel
approved these changes
May 13, 2025
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes a bug related to an incorrect conversion from a boolean to size_t in the index kernel eligibility check.
- Corrects the type conversion on the strides(1)[1] comparison
- Ensures the check correctly compares the numerical value against 0
Comments suppressed due to low confidence (1)
src/ATen/native/xpu/sycl/IndexKernelUtils.h:32
- The updated conversion now correctly casts the actual stride value before comparing it to 0, thereby fixing the logical error.
static_cast<size_t>(iter.strides(1)[1]) == 0 &&
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the logical error caused by incorrect type conversion from boolean to size_t.