Configure the timeout and retry count between the master and worker. #1645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhengchenyu
requested review from
BalaBalaYi,
majieyue,
samplise,
way-zer and
workingloong
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1645 +/- ##
=======================================
Coverage 80.05% 80.06%
=======================================
Files 228 228
Lines 22117 22127 +10
=======================================
+ Hits 17705 17715 +10
Misses 4412 4412 ☔ View full report in Codecov by Sentry. |
BalaBalaYi
requested changes
Oct 21, 2025
| training_log_file: str = "" | ||
| failure_node_errors: str = "" | ||
| numa_affinity: bool = False | ||
| connect_master_timeout = 300 |
Collaborator
There was a problem hiding this comment.
It's unnecessary to define these two parameters here. You can refer to the timeout mechanism inside the master server/client and leverage existing parameters (by exposing them via config).
Additionally, note that these parameters should not be passed through dlrover-run; instead, they should be directly obtained by the master through job args.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Configure the below parameter which is constant before.
Why are the changes needed?
In some scenarios, these non-configurable default values are set too large, resulting in, for example, a 10-minute hang time.
Does this PR introduce any user-facing change?
Add all config have default value.
How was this patch tested?
Real job.