Skip to content

Conversation

@mkurapov
Copy link
Contributor

@mkurapov mkurapov commented Oct 24, 2025

Changes proposed in this pull request

  • Add WALLET_ADDRESS_NOT_FOUND_POLLING_ENABLED flag to backend, false by default
  • Webhook + poll wallet address creation only during Open Payments lookups if this flag is enabled

Context

Fixes #3720 | RAF-1197

Checklist

  • Related issues linked using fixes #number
  • Tests added/updated
  • Make sure that all checks pass
  • Bruno collection updated (if necessary)
  • Documentation issue created with user-docs label (if necessary)
  • OpenAPI specs updated (if necessary)

@netlify
Copy link

netlify bot commented Oct 24, 2025

Deploy Preview for brilliant-pasca-3e80ec canceled.

Name Link
🔨 Latest commit 186fa6b
🔍 Latest deploy log https://app.netlify.com/projects/brilliant-pasca-3e80ec/deploys/68fb8eb321ca810008138378

@github-actions github-actions bot added type: tests Testing related pkg: backend Changes in the backend package. type: source Changes business logic labels Oct 24, 2025
@mkurapov mkurapov marked this pull request as ready for review October 24, 2025 14:19
@mkurapov mkurapov requested a review from BlairCurrey October 24, 2025 14:19
@github-actions
Copy link

github-actions bot commented Oct 24, 2025

🚀 Performance Test Results

Test Configuration:

  • VUs: 4
  • Duration: 1m0s

Test Metrics:

  • Requests/s: 43.00
  • Iterations/s: 14.33
  • Failed Requests: 0.00% (0 of 2587)
📜 Logs

> [email protected] run-tests:testenv /home/runner/work/rafiki/rafiki/test/performance
> ./scripts/run-tests.sh -e test "-k" "-q" "--vus" "4" "--duration" "1m"

Cloud Nine GraphQL API is up: http://localhost:3101/graphql
Cloud Nine Wallet Address is up: http://localhost:3100/
Happy Life Bank Address is up: http://localhost:4100/
cloud-nine-wallet-test-backend already set
cloud-nine-wallet-test-auth already set
happy-life-bank-test-backend already set
happy-life-bank-test-auth already set
     data_received..................: 934 kB 16 kB/s
     data_sent......................: 2.0 MB 33 kB/s
     http_req_blocked...............: avg=7.43µs   min=2.04µs   med=5.18µs   max=1.68ms   p(90)=6.39µs   p(95)=7µs     
     http_req_connecting............: avg=1.4µs    min=0s       med=0s       max=1.64ms   p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=92.39ms  min=9.3ms    med=76.49ms  max=548.41ms p(90)=156.49ms p(95)=172.46ms
       { expected_response:true }...: avg=92.39ms  min=9.3ms    med=76.49ms  max=548.41ms p(90)=156.49ms p(95)=172.46ms
     http_req_failed................: 0.00%  ✓ 0         ✗ 2587
     http_req_receiving.............: avg=88.8µs   min=28.36µs  med=78.79µs  max=1.79ms   p(90)=121.07µs p(95)=152.41µs
     http_req_sending...............: avg=35.39µs  min=9.17µs   med=27.43µs  max=1.16ms   p(90)=40.03µs  p(95)=55.9µs  
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=92.26ms  min=9.13ms   med=76.28ms  max=548.26ms p(90)=156.29ms p(95)=172.36ms
     http_reqs......................: 2587   42.998446/s
     iteration_duration.............: avg=278.91ms min=182.61ms med=266.87ms max=1.06s    p(90)=327.85ms p(95)=361.76ms
     iterations.....................: 862    14.327275/s
     vus............................: 4      min=4       max=4 
     vus_max........................: 4      min=4       max=4 

@mkurapov mkurapov merged commit 3614303 into main Oct 27, 2025
97 of 139 checks passed
@mkurapov mkurapov deleted the max/rop-14 branch October 27, 2025 11:45
mkurapov added a commit that referenced this pull request Oct 27, 2025
* feat(backend): add optional WALLET_ADDRESS_NOT_FOUND_POLLING_ENABLED env var

* feat(backend): only poll for wallet addresses if WALLET_ADDRESS_NOT_FOUND_POLLING_ENABLED true

* feat(localenv): set WALLET_ADDRESS_NOT_FOUND_POLLING_ENABLED to true for hlb

* test(backend): update wallet address route tests

* chore(integration): enable WALLET_ADDRESS_NOT_FOUND_POLLING_ENABLED in hlb
# Conflicts:
#	localenv/happy-life-bank/docker-compose.yml
#	test/testenv/happy-life-bank/docker-compose.yml
mkurapov added a commit that referenced this pull request Oct 27, 2025
* feat(backend): add optional WALLET_ADDRESS_NOT_FOUND_POLLING_ENABLED env var

* feat(backend): only poll for wallet addresses if WALLET_ADDRESS_NOT_FOUND_POLLING_ENABLED true

* feat(localenv): set WALLET_ADDRESS_NOT_FOUND_POLLING_ENABLED to true for hlb

* test(backend): update wallet address route tests

* chore(integration): enable WALLET_ADDRESS_NOT_FOUND_POLLING_ENABLED in hlb
# Conflicts:
#	localenv/happy-life-bank/docker-compose.yml
#	test/testenv/happy-life-bank/docker-compose.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: backend Changes in the backend package. type: source Changes business logic type: tests Testing related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add environment variable for configuring wallet address not found polling

2 participants