Add tests for Bookreader/utils.test.js - #1590
Open
duggiefresh wants to merge 2 commits into
Open
duggiefresh wants to merge 2 commits into
duggiefresh wants to merge 2 commits into
Conversation
This adds missing tests for a handful of `Bookreader/utils` functions. Adds tests for: * `arrChanged` * `arrEquals` * `calcScreenDPI` * `disableSelect` * `genToArray` * `getIFrameDocument` * `notInArray` * `sortBy` * `sum` * `throttle`
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1590 +/- ##
==========================================
+ Coverage 63.81% 63.93% +0.12%
==========================================
Files 69 69
Lines 6256 6256
Branches 1391 1391
==========================================
+ Hits 3992 4000 +8
+ Misses 2225 2217 -8
Partials 39 39 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds missing tests for a handful of
Bookreader/utilsfunctions.Adds tests for:
arrChangedarrEqualscalcScreenDPIdisableSelectgenToArraygetIFrameDocumentnotInArraysortBysumthrottle