Tighten account creation validations #10486
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimchamp
commented
Feb 20, 2025
Comment on lines
+10
to
+17
| INVALIDATING_ERRORS = [ | ||
| "invalid-input-secret", | ||
| "missing-input-secret", | ||
| "missing-input-response", | ||
| "invalid-input-response", | ||
| "bad-request", | ||
| "timeout-or-duplicate", | ||
| ] |
cdrini
approved these changes
Feb 20, 2025
| @@ -38,6 +50,6 @@ def validate(self, value=None): | |||
| data = r.json() | |||
| if not data.get('success', False) and 'error-codes' in data: | |||
| logger.error(f"Recaptcha Error: {data['error-codes']}") | |||
| return True | |||
| return accept_error(data['error-codes']) | |||
There was a problem hiding this comment.
This might be more easily done with some set logic:
Suggested change
| return accept_error(data['error-codes']) | |
| return not (set(data['error-codes']) & INVALIDATING_ERRORS) |
Ie check that the provided errors don't intersect the invalidating errors. But it's the same, so just a suggestion.
jimchamp
added
the
Patch Deployed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that legitimately invalid ReCaptcha tests cause account creation form validations to fail.
Technical
Testing
Screenshot
Stakeholders