Skip to content

[IN-145] fix: remove parts from finish endpoint#213

Merged
apsantiso merged 2 commits into
masterfrom
refactor/remove-parts-from-finish-endpoint
May 4, 2026
Merged

[IN-145] fix: remove parts from finish endpoint#213
apsantiso merged 2 commits into
masterfrom
refactor/remove-parts-from-finish-endpoint

Conversation

@apsantiso
Copy link
Copy Markdown

@apsantiso apsantiso commented Apr 28, 2026

We're increasing the upload size limit to 100GB. Since parts are ~30MB each, large files can generate 3,000+ parts, sending the full parts array in the request body causes 413 Payload Too Large errors.

Changes

  1. Do not take parts into account when validating uploadId
  2. Added e2e tests to ensure nothing breaks

⚠️ UploadId is an opaque token, so format validation should not be performed.

@apsantiso apsantiso force-pushed the refactor/remove-parts-from-finish-endpoint branch from 59b21e1 to 6fa8ebc Compare April 30, 2026 15:04
@apsantiso apsantiso force-pushed the refactor/remove-parts-from-finish-endpoint branch from 6fa8ebc to 654cf17 Compare April 30, 2026 18:29
@apsantiso apsantiso self-assigned this May 4, 2026
@apsantiso apsantiso marked this pull request as ready for review May 4, 2026 09:15
@apsantiso apsantiso requested a review from sg-gs as a code owner May 4, 2026 09:15
@apsantiso apsantiso changed the title refactor: remove parts from finish endpoint fix: remove parts from finish endpoint May 4, 2026
@apsantiso apsantiso merged commit a4426d4 into master May 4, 2026
10 of 11 checks passed
@apsantiso apsantiso deleted the refactor/remove-parts-from-finish-endpoint branch May 4, 2026 12:03
@apsantiso apsantiso changed the title fix: remove parts from finish endpoint [IN-145] fix: remove parts from finish endpoint May 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants