Remove get machine guid #1225
Merged
Remove get machine guid #1225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egalvis27
approved these changes
Jan 2, 2026
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
In a previous pull request, we migrated
electron-storeto always use the pathC:\Users\user\AppData\Roaming\internxt-drive\config.json, which makes it easier to verify ifconfig.jsonis deleted after uninstallation.After testing,
config.json(and the entireinternxt-drivefolder) remains intact. We reused the device, the token, and everything contained withinconfig.json.This means that obtaining the machine GUID is not too necessary, as the user needs to manually delete the folder to remove the device and we will need to change also how we store the backup paths.