[PB-5386] fix / Sharing invites are not listed if their item_id is removed #839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apsantiso
had a problem deploying
to
development
GitHub Actions
Failure
apsantiso
temporarily deployed
to
development
GitHub Actions
Inactive
apsantiso
temporarily deployed
to
development
GitHub Actions
Inactive
apsantiso
temporarily deployed
to
development
GitHub Actions
Inactive
apsantiso
force-pushed
the
fix/stop-listing-sharings-if-item-is-deleted
branch
from
e882515 to
ea29f35
Compare
apsantiso
temporarily deployed
to
development
GitHub Actions
Inactive
apsantiso
temporarily deployed
to
development
GitHub Actions
Inactive
apsantiso
temporarily deployed
to
development
GitHub Actions
Inactive
apsantiso
temporarily deployed
to
development
GitHub Actions
Inactive
|
|
This PR is stale because it has been open for more than 15 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're listing sharing invites with their item already deleted.
We have a background process that deletes files and folders when their parent is deleted, so we do not have a way to remove the sharings and invites without modifying and adding complexity to the query and the code of that background job, as we want to avoid it, this PR fixes it by including a filter in the query to filter out any sharing with its item deleted.