[PB-5957]: fix/remove max space occupied pre-check for shared uploads - #1931
Merged
Merged
Conversation
Deploying drive-web with
|
| Latest commit: |
1d8b90f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://73ff5c35.drive-web.pages.dev |
| Branch Preview URL: | https://fix-remove-is-upload-allowed.drive-web.pages.dev |
CandelR
reviewed
Apr 15, 2026
CandelR
left a comment
CandelR
left a comment
Collaborator
There was a problem hiding this comment.
Waiting the modal that warns the user that the owner hasn't enough space :)
Contributor
Author
|
The reached plan dialog has been modified for shared folders. See the attached image to see how it looks now for shared folders. |
CandelR
previously approved these changes
Apr 15, 2026
sg-gs
approved these changes
Apr 16, 2026
CandelR
approved these changes
Apr 17, 2026
larryrider
approved these changes
Apr 17, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removing the pre-check of max space occupied when the user is uploading items on shared folders. This was causing problems when a user with EDITOR role is uploading items, because we were checking if the user has free space in his account, not the owner account.
Related Issues
Related Pull Requests
Checklist
Testing Process
Additional Notes