Skip to content

[PB-3787]: bugfix/Fix join conference in dev mode #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
CandelR wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[PB-3787]: bugfix/Fix join conference in dev mode #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions react/features/base/connection/actions.any.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ import {
} from './actionTypes';
import { JITSI_CONNECTION_URL_KEY } from './constants';
import logger from './logger';
import { ConnectionFailedError, IIceServers } from './types';
import { get8x8AppId, get8x8Options, get8x8JWT } from './options8x8';
import { get8x8AppId, get8x8JWT, get8x8Options } from "./options8x8";
import { ConnectionFailedError, IIceServers } from "./types";

/**
* The options that will be passed to the JitsiConnection instance.
Expand Down Expand Up @@ -155,7 +155,9 @@ export function constructOptions(state: IReduxState) {
options.websocketKeepAliveUrl = appendURLParam(options.websocketKeepAliveUrl, 'room', roomName ?? '');
}
if (options.conferenceRequestUrl) {
options.conferenceRequestUrl = appendURLParam(options.conferenceRequestUrl, 'room', roomName ?? '');
// COMMENTED appendURLParam to force use of xmpp protocol instead of http to join a conference
// because its http request is not working
options.conferenceRequestUrl = undefined; //appendURLParam(options.conferenceRequestUrl, "room", roomName ?? "");
}
}

Expand Down
Loading