Skip to content

An alternative for autoAdjustName #1563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

hsyhhssyy
Copy link
Contributor

This PR fixes #1559

image

We could turn autoAdjustName into a selectable setting.
The default option, Create, would adjust names only when a file is created—matching the current behavior when the flag is set to false.
Choosing Create, Copy, and Move would mimic the behavior of true.
Finally, selecting Never would leave files on disk exactly as they are, which is the outcome I personally prefer.

@hsyhhssyy hsyhhssyy requested a review from isc-bsaviano as a code owner May 23, 2025 07:54
@hsyhhssyy
Copy link
Contributor Author

hsyhhssyy commented May 23, 2025

Might be a bug: when you select “Create, Copy and Move” (or set AutoAdjustName to yes as it works now) and drag-and-drop to move a file from one workspace folder to another, the file’s contents stay the same.

Might be a bug: when the file's first line is comment in ///, the adjusted class definitions will be placed incorrectly when saving from new file. (I’ll open a new issue for this after the dust has settled on the autoAdjustName issue.)

@isc-bsaviano
Copy link
Contributor

Hi @hsyhhssyy, I appreciate the PR but after reviewing this with another maintainer we've decided to reject it. We think it's desirable for the stubs to always be generated for new files. Since the stubs are not auto-saved, you can remove them using Ctrl-Z if they are unwanted. Thanks for your interest in this extension!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

objectscript.autoAdjustName behavior changed on client-side editing
2 participants