Individual cite links#363
Merged
Merged
Conversation
pulling from upstream
sneakers-the-rat
commented
Jan 2, 2026
sneakers-the-rat
commented
Jan 2, 2026
sneakers-the-rat
marked this pull request as ready for review
January 2, 2026 04:21
Contributor
Author
|
I don't really understand the windows test failures here, it looks like they're just failing to load the bibliography and instead returning |
Owner
|
Thanks! The Windows issues are indeed unrelated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #352
This isn't done, and probably isn't the best way to do this, but figured id open it as a starting point instead of just sitting on it in my fork.
this renders group citations with individual links to each of their cites like this (red border added to accentuate their being separate links)
what it doesn't do is handle styles that would want to render
[1-4], but i figured you'd know how to handle that better than i do - i tried to walk up through citeproc to see if i could mimic the process of joining multiple rendered citations, but i couldn't find it. reading ruby is still sort of hard to me, never sure where things get defined.but if we like this general approach and you have some guidance on how to get that problem resolved, i'll write tests and finish this up