Skip to content

Individual cite links#363

Merged
inukshuk merged 6 commits into
inukshuk:mainfrom
sneakers-the-rat:individual-cite-links
Jan 3, 2026
Merged

Individual cite links#363
inukshuk merged 6 commits into
inukshuk:mainfrom
sneakers-the-rat:individual-cite-links

Conversation

@sneakers-the-rat

Copy link
Copy Markdown
Contributor

Fix #352

This isn't done, and probably isn't the best way to do this, but figured id open it as a starting point instead of just sitting on it in my fork.

this renders group citations with individual links to each of their cites like this (red border added to accentuate their being separate links)

Screenshot 2025-03-30 at 7 51 41 PM
Screenshot 2025-03-30 at 8 16 42 PM

what it doesn't do is handle styles that would want to render [1-4], but i figured you'd know how to handle that better than i do - i tried to walk up through citeproc to see if i could mimic the process of joining multiple rendered citations, but i couldn't find it. reading ruby is still sort of hard to me, never sure where things get defined.

but if we like this general approach and you have some guidance on how to get that problem resolved, i'll write tests and finish this up

Comment thread features/citation.feature
Comment thread features/bibtex.feature
@sneakers-the-rat
sneakers-the-rat marked this pull request as ready for review January 2, 2026 04:21
@sneakers-the-rat

Copy link
Copy Markdown
Contributor Author

I don't really understand the windows test failures here, it looks like they're just failing to load the bibliography and instead returning missing_reference, however the leg of the cite method that returns missing_reference is outside the changes made in this PR - i.e. this PR doesn't change the path that would be taken to get to missing_reference, so i'm not quite sure if/how i caused those failures.

@inukshuk

inukshuk commented Jan 3, 2026

Copy link
Copy Markdown
Owner

Thanks! The Windows issues are indeed unrelated.

@inukshuk
inukshuk merged commit 5b1a4e8 into inukshuk:main Jan 3, 2026
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Individually linked citations in multiple citations

2 participants