Skip to content

Conversation

@carlinmack
Copy link
Contributor

❤️ Thank you for your contribution!

Description

Please describe briefly your pull request.

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

@carlinmack carlinmack moved this to In review 🔍 in Sprint Q4/2025 Sep 25, 2025
Copy link
Member

@zzacharo zzacharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carlinmack this looks good to me, do you still work on it?

@carlinmack
Copy link
Contributor Author

nope this is ready :)

{% from "invenio_requests/macros/request_header.html" import inclusion_request_header %}

{% set title = invenio_request.title %}
{% set base_template = admin_base_template %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice thought for reusing templates - just a little warning, you might be in trouble though to provide all the context needed for the parent template to work, especially when making changes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion, to be tested if it wasn't done yet: all the request views

Copy link
Contributor

@sakshamarora1 sakshamarora1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sakshamarora1 sakshamarora1 moved this from In review 🔍 to To release 🤖 in Sprint Q4/2025 Nov 7, 2025
@sakshamarora1 sakshamarora1 moved this from To release 🤖 to In progress in Sprint Q4/2025 Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In progress

Development

Successfully merging this pull request may close these issues.

4 participants