feat(vertexai): integrate Claude model support#14
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces support for Anthropic Claude models within the Genkit Vertex AI plugin. Key changes include the implementation of a VertexClaudeModelFactory to handle model interactions, updates to the plugin to list and resolve Anthropic publisher models, and new documentation and examples. Feedback focuses on critical technical refinements: ensuring image inputs are base64-encoded to meet API requirements, renaming internal tools to prevent user-defined conflicts, optimizing tool output encoding, and correcting non-standard regional endpoint URLs.
| ) { | ||
| final systemMessage = req.messages | ||
| .where((m) => m.role == Role.system) | ||
| .firstOrNull; |
There was a problem hiding this comment.
can we have multiple system messages here?
There was a problem hiding this comment.
Could do, but consider:
genkit_openai: allows/preserves multiple system messages.
genkit_anthropic: only uses first, drops the rest.
genkit_google_genai: only uses first, drops the rest.
genkit_firebase_ai: only uses first, drops the rest.
Should we?
455b597 to
9d625b2
Compare
Removes a chrome warning at runtime
|
|
Adds support for Claude models in VertexAI plugin
Testing