Skip to content

docs(auth): fix function name shadowing #8513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DoctorJohn
Copy link
Contributor

Description

This PR fixes that the onAuthStateChanged function name was shadowed in one of the authentication examples.

Related issues

  • Starting with docs(auth): update examples to use modular API #8327, the callback's name conflicts with the onAuthStateChanged function's name when imported from the modular API. Previously, that was not an issue because the function was used via auth.onAuthStateChanged, which avoided the naming conflict.

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
    • Other (macOS, web)
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

  • I double checked that this was the only example where I forgot to rename the callback to avoid naming conflicts
  • I'll triple-check once the docs preview gets posted by the bot :)

🔥


Think react-native-firebase is great? Please consider supporting the project with any of the below:

Copy link

vercel bot commented May 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 4, 2025 5:10pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant