security: validate custom node pack names#9256
Open
Ersa-tech wants to merge 1 commit into
Open
Conversation
Signed-off-by: Security Researcher <security@example.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validates custom node pack names before using them in filesystem paths during install and uninstall operations.
Security impact
The custom node installer derived
pack_namedirectly from the submitted git source and then used it for clone targets, module loading, tags, and cleanup paths. This change rejects empty names, dot segments, path separators, and unsafe characters before any filesystem operation is attempted.This is especially important on Windows, where backslashes in a URL segment can be interpreted as path separators when building
Pathtargets.Changes
Verification
python -m py_compile invokeai/app/api/routers/custom_nodes.py tests/app/routers/test_custom_nodes.pyI could not run the focused pytest module locally because the checkout is missing the
blake3dependency before test collection reaches this module.