Clear the AC flag before capturing it #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also ran into this exact problem in my testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some systems, the AC flag was already set when it is captured by SimpleVisor. This results in skipping initialization of the hypervisor and
The SHV failed to initialize (0xFFFFFFFD) Failed CPU: 0error because the subsequent check after capturing believes the hypervisor was already set up.I found my VM (18362.1.amd64fre.19h1_release.190318-1202) hit this case.
This change clears the flag prior to capturing and checking the flag, ensuring initialization happens.