This repository was archived by the owner on Jan 6, 2023. It is now read-only.
Fix for 'package download' failing with proxy#100
Open
errant01 wants to merge 1 commit intoionic-team:masterfrom
Open
Fix for 'package download' failing with proxy#100errant01 wants to merge 1 commit intoionic-team:masterfrom
errant01 wants to merge 1 commit intoionic-team:masterfrom
Conversation
The call to requestProgess which handles the actual file download is missing the proxy parameter that allows it to work from behind proxies. This PR adds the parameter. It has been tested in my proxy environment and resolves the problem. Error received before fix: 16:12:47 + ionic package download 5 16:12:49 16:12:49 Error: tunneling socket could not be established, cause=write EPROTO 140355477145408:error:140770FC:SSL routines:SSL23_GET_SERVER_HELLO:unknown protocol:../deps/openssl/openssl/ssl/s23_clnt.c:794: 16:12:49 16:12:49 at ClientRequest.onError (/var/lib/jenkins/.nvm/versions/node/v4.4.3/lib/node_modules/ionic/node_modules/tunnel-agent/index.js:176:17) 16:12:49 at ClientRequest.g (events.js:260:16) 16:12:49 at emitOne (events.js:77:13) 16:12:49 at ClientRequest.emit (events.js:169:7) 16:12:49 at TLSSocket.socketErrorListener (_http_client.js:256:9) 16:12:49 at emitOne (events.js:77:13) 16:12:49 at TLSSocket.emit (events.js:169:7) 16:12:49 at onwriteError (_stream_writable.js:313:10) 16:12:49 at onwrite (_stream_writable.js:331:5) 16:12:49 at WritableState.onwrite (_stream_writable.js:89:5) 16:12:49 16:12:49 tunneling socket could not be established, cause=write EPROTO 140355477145408:error:140770FC:SSL routines:SSL23_GET_SERVER_HELLO:unknown protocol:../deps/openssl/openssl/ssl/s23_clnt.c:794: 16:12:49 (CLI v1.7.14)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The call to requestProgess which handles the actual file download is missing the proxy parameter that allows it to work from behind proxies. This PR adds the parameter. It has been tested in my proxy environment and resolves the problem.
Error received before fix:
16:12:47 + ionic package download 5
16:12:49
16:12:49 Error: tunneling socket could not be established, cause=write EPROTO 140355477145408:error:140770FC:SSL routines:SSL23_GET_SERVER_HELLO:unknown protocol:../deps/openssl/openssl/ssl/s23_clnt.c:794:
16:12:49
16:12:49 at ClientRequest.onError (/var/lib/jenkins/.nvm/versions/node/v4.4.3/lib/node_modules/ionic/node_modules/tunnel-agent/index.js:176:17)
16:12:49 at ClientRequest.g (events.js:260:16)
16:12:49 at emitOne (events.js:77:13)
16:12:49 at ClientRequest.emit (events.js:169:7)
16:12:49 at TLSSocket.socketErrorListener (_http_client.js:256:9)
16:12:49 at emitOne (events.js:77:13)
16:12:49 at TLSSocket.emit (events.js:169:7)
16:12:49 at onwriteError (_stream_writable.js:313:10)
16:12:49 at onwrite (_stream_writable.js:331:5)
16:12:49 at WritableState.onwrite (_stream_writable.js:89:5)
16:12:49
16:12:49 tunneling socket could not be established, cause=write EPROTO 140355477145408:error:140770FC:SSL routines:SSL23_GET_SERVER_HELLO:unknown protocol:../deps/openssl/openssl/ssl/s23_clnt.c:794:
16:12:49 (CLI v1.7.14)