Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(overlays): exclude backdrop-no-scroll class when toast is presented #30123

Merged
merged 4 commits into from
Apr 1, 2025
Merged

fix(overlays): exclude backdrop-no-scroll class when toast is presented #30123

merged 4 commits into from
Apr 1, 2025

Conversation

tobiloeb
Copy link
Contributor

@tobiloeb tobiloeb commented Jan 9, 2025 •
edited by thetaPC
Loading

Issue number: resolves #30112

What is the current behavior?

When toast is presented, the backdrop-no-scroll class is added to the body when using Frameworks like Angular. It should not add this class as toast does not be setting focus trap as mentioned in the comments.

What is the new behavior?

  • Class is only added when the overlay that is presented is not a toast component.
  • Test was added.

Does this introduce a breaking change?

  • Yes
  • No

Other information

N/A

@tobiloeb
fix(toast): remove backdrop-no-scroll for last toast overlay
ab25c71 
In case last overlay is a toast, the backdrop-no-scroll css class is removed from body.

closes ionic-team#30112
@tobiloeb tobiloeb requested a review from a team as a code owner January 9, 2025 09:52
@tobiloeb tobiloeb requested a review from joselrio January 9, 2025 09:52
@vercel Vercel
Copy link

vercel bot commented Jan 9, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 25, 2025 11:23pm

@github-actions github-actions bot added the package: core @ionic/core package label Jan 9, 2025
@thetaPC thetaPC removed the request for review from joselrio March 21, 2025 20:29
@thetaPC thetaPC changed the title fix(toast): remove backdrop-no-scroll for last toast overlay fix(overlays): remove backdrop-no-scroll class after last overlay is dismissed Mar 21, 2025
@thetaPC thetaPC changed the title fix(overlays): remove backdrop-no-scroll class after last overlay is dismissed fix(overlays): exclude backdrop-no-scroll class when toast is presented Mar 25, 2025
ShaneK
ShaneK approved these changes Apr 1, 2025
View reviewed changes
Copy link
Member

@ShaneK ShaneK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@thetaPC thetaPC added this pull request to the merge queue Apr 1, 2025
Merged via the queue into ionic-team:main with commit 7f9df7a Apr 1, 2025
52 checks passed
@thetaPC thetaPC mentioned this pull request Apr 1, 2025
Closed
3 tasks
@thetaPC
Copy link
Contributor

thetaPC commented Apr 1, 2025

@tobiloeb Thank you for the PR! And congrats to your first PR with Ionic Framework!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaneK ShaneK ShaneK approved these changes

@brandyscarney brandyscarney brandyscarney approved these changes

Assignees
No one assigned
Labels
package: core @ionic/core package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: ion-toast does not remove backdrop-no-scroll from body when dismiss
4 participants
@tobiloeb @thetaPC @ShaneK @brandyscarney