fix(item): emit click event once when clicking padded space on item and emit correct element #30373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
brandyscarney
changed the title
brandyscarney
commented
Apr 25, 2025
There was a problem hiding this comment.
This was moved to checkbox/test/item to match the other components.
brandyscarney
commented
Apr 25, 2025
There was a problem hiding this comment.
This is required for input, otherwise you can click on the native-wrapper and get another click event.
brandyscarney
commented
Apr 25, 2025
There was a problem hiding this comment.
This was moved to select/test/item to match the other components.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #29758 resolves #29761
What is the current behavior?
When an
ion-itemhas a click event listener, the following issues occur:ion-checkbox,ion-toggle,ion-radio,ion-textarea,ion-input) triggers the click event twice.ion-inputandion-textarea, clicking their native inputs reports the wrong element as the event target.native-wrapperofion-inputemits a separate click event with an incorrect target element.What is the new behavior?
firstInteractive.click()in Item for all interactives (no longer excludes input/textarea).ion-input/ion-textareainstead of the native input elements.native-wrappertriggering its own click event when clicking on its padding.Does this introduce a breaking change?
Other information
Dev build:
8.5.6-dev.11745613928.16440384Previews: