-
Notifications
You must be signed in to change notification settings - Fork 13.5k
fix(header, content): update colors for ionic theme #30491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes don't seem to be necessary as it's working as expected. I would recommend providing a minimal JS environment that shows what the issue is so we can provide a different solution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are these changes needed? This is already being set through the modal ionic theme file.
The background is updating as expected when I change it locally:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are these changes needed? This can already be done through styling:
ion-modal ion-header ion-toolbar {
--background: pink;
}
We have documentation on best practices for style customization when it comes to modals. I would recommend reviewing that.
Issue number: resolves #
What is the current behavior?
What is the new behavior?
in-modal
to header and content when used inside the modal.Does this introduce a breaking change?
Other information
https://ionic-framework-git-rou-11977-v2-ionic1.vercel.app/src/components/modal/test/basic?ionic:theme=ionic