Skip to content

Fix building with LLVM 23 - #5539

Open
viktormalik wants to merge 1 commit into
iovisor:masterfrom
viktormalik:llvm-23
Open

Fix building with LLVM 23#5539
viktormalik wants to merge 1 commit into
iovisor:masterfrom
viktormalik:llvm-23

Conversation

@viktormalik

Copy link
Copy Markdown

Description

As usually, new LLVM introduced breaking API changes.

This time, it's just a single breakage for BCC - the MCContext constructor now accepts MCAsmInfo, MCRegisterInfo, and MCSubtargetInfo by a reference rather than by a pointer.

Checklist

  • Commit prefix matches changed area (e.g., tools/toolname:, libbpf-tools/toolname:, src/cc:, docs:, build:, tests/python:)
  • Commit body explains why this change is needed

Two LLVM 23 patches [1,2] changed the MCContext constructor to take
MCAsmInfo, MCRegisterInfo, and MCSubtargetInfo by a reference rather
than by a pointer. Reflect the change in call of the constructor.

[1] llvm/llvm-project@13e98d8
[2] llvm/llvm-project@d50631f

Signed-off-by: Viktor Malik <viktor.malik@gmail.com>

@jordalgo jordalgo left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants