Conversation
ipa-rwu
force-pushed
the
rwu/fix/ci
branch
3 times, most recently
from
62add0f to
1d926ce
Compare
- Updated the generated files to reflect the new Xtext version (2.39.0). - Changed Java SE version from 19 to 21 in .classpath and .settings/org.eclipse.jdt.core.prefs. - Updated MANIFEST.MF to require Java SE 21. - Adjusted the expected size of the injectors map in XtextActivator. - Modified pom.xml to use the variable for MWE2 version. - Cleaned up whitespace and formatting in various generator files for consistency. - Added a new utility method to remove leading slashes in GeneratorHelpers.
Member
|
@ipa-rwu Wow, many thanks for fixing this CI system 👏🏽 👏🏽 |
Member
Author
I usually run pre-commit to format before pushing. https://github.com/ipa320/RosTooling/blob/main/.pre-commit-config.yaml |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ipa-nhg
This pull request upgrades the Java version used across the project from Java 19 (and in some places Java 11/1.8) to Java 21. It also updates related build tools and dependencies to ensure compatibility with Java 21. The changes affect build configuration files, Maven POMs, Eclipse project settings, and GitHub Actions workflows.
Key changes include:
Java Version Upgrade:
.classpathfiles and.settings/org.eclipse.jdt.core.prefsto use JavaSE-21 instead of JavaSE-19 or earlier. [1] [2] [3] [4] [5]Bundle-RequiredExecutionEnvironmentinMANIFEST.MFfiles for plugins to JavaSE-21. [1] [2]Build and Dependency Updates:
pom.xmlfiles, and upgraded related plugin and dependency versions (xtextVersion,tycho-version,mwe2Version). [1] [2]Other minor changes: