Merged
Conversation
… as ros.Parameters and not RosParameters, they are the node-local parameters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The global parameters are defined ros.Parameters(*) and not RosParameters, they are the node-local parameters. The current status is not working and breaks the rossystem files compilation while parameters are defined. tested with https://github.com/ipa-nhg/RosModelsCatalog/blob/main/arms/UR/ur_robot.rossystem
(*)
RosTooling/plugins/de.fraunhofer.ipa.rossystem/model/rossystem.ecore
Lines 13 to 15 in 7facff1
RosTooling/plugins/de.fraunhofer.ipa.rossystem.xtext/src/de/fraunhofer/ipa/rossystem/RosSystem.xtext
Lines 34 to 38 in 7facff1
RosTooling/plugins/de.fraunhofer.ipa.ros.xtext/src/de/fraunhofer/ipa/ros/Basics.xtext
Lines 41 to 49 in 7facff1