Skip to content

Commit 75faacc

Browse files
committed
Fix test assertions in python 12
1 parent 4682bea commit 75faacc

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

password_policies/tests/test_models.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,4 +23,4 @@ def test_password_history_expiration(self):
2323
self.assertEqual(count, settings.PASSWORD_HISTORY_COUNT)
2424

2525
def test_password_history_recent_passwords(self):
26-
self.failIf(PasswordHistory.objects.check_password(self.user, passwords[-1]))
26+
self.assertFalse(PasswordHistory.objects.check_password(self.user, passwords[-1]))

password_policies/tests/test_views.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ def test_password_change(self):
3030
self.client.login(username="alice", password=passwords[-1])
3131
response = self.client.get(reverse("password_change"))
3232
self.assertEqual(response.status_code, 200)
33-
self.failUnless(
33+
self.assertTrue(
3434
isinstance(response.context["form"], PasswordPoliciesChangeForm)
3535
)
3636
self.assertTemplateUsed(response, "registration/password_change_form.html")
@@ -50,7 +50,7 @@ def test_password_change_failure(self):
5050
self.client.login(username="alice", password=passwords[-1])
5151
response = self.client.post(reverse("password_change"), data=data)
5252
self.assertEqual(response.status_code, 200)
53-
self.failIf(response.context["form"].is_valid())
53+
self.assertFalse(response.context["form"].is_valid())
5454
self.assertFormError(response, "form", field="old_password", errors=msg)
5555
self.client.logout()
5656

@@ -107,7 +107,7 @@ def test_password_change_wrong_validators(self):
107107
self.client.login(username="alice", password=data["old_password"])
108108
response = self.client.post(reverse("password_change"), data=data)
109109
self.assertEqual(response.status_code, 200)
110-
self.failIf(response.context["form"].is_valid())
110+
self.assertFalse(response.context["form"].is_valid())
111111
self.assertFormError(response, "form", field="new_password2", errors=msg)
112112
self.client.logout()
113113

0 commit comments

Comments
 (0)