test: Block header validation fixes

[gumb0]

No description provided.

[codecov]

Codecov Report

Attention: Patch coverage is 85.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 94.41%. Comparing base (18b8e95) to head (887d5a0).
Report is 6 commits behind head on master.

Files with missing lines	Patch %	Lines
test/blockchaintest/blockchaintest_runner.cpp	84.21%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1244      +/-   ##
==========================================
- Coverage   94.55%   94.41%   -0.14%     
==========================================
  Files         175      175              
  Lines       19714    19732      +18     
==========================================
- Hits        18640    18630      -10     
- Misses       1074     1102      +28     

Flag	Coverage Δ
eest_gmp	15.26% <0.00%> (-0.01%)	⬇️
eof_execution_spec_tests	19.90% <80.00%> (+0.04%)	⬆️
ethereum_tests	?
ethereum_tests_silkpre	18.27% <0.00%> (-0.01%)	⬇️
execution_spec_tests	18.78% <85.00%> (+0.23%)	⬆️
unittests	91.75% <5.00%> (-0.06%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
test/blockchaintest/blockchaintest_loader.cpp	93.13% <100.00%> (-5.88%)	⬇️
test/state/block.hpp	100.00% <ø> (+33.33%)	⬆️
test/blockchaintest/blockchaintest_runner.cpp	80.26% <84.21%> (-5.39%)	⬇️

... and 9 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[pdobacz]

@gumb0 Hi, this looks like a better version of #1347 I've been working on, do you mind if I take over? (it seems to build and pass respective tests after rebase)

CC @chfast thanks for flagging

[pdobacz]

I rebased and pushed, let us know if there was anything which could stop us from moving ahead with this.

[codecov]

Codecov Report

❌ Patch coverage is 72.00000% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.82%. Comparing base (543457a) to head (211c230).
⚠️ Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
test/blockchaintest/blockchaintest_runner.cpp	70.83%	2 Missing and 5 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1244      +/-   ##
==========================================
- Coverage   84.83%   84.82%   -0.01%     
==========================================
  Files         169      169              
  Lines       20356    20373      +17     
  Branches     4121     4125       +4     
==========================================
+ Hits        17268    17281      +13     
- Misses        438      440       +2     
- Partials     2650     2652       +2     

Flag	Coverage Δ
eest-develop	80.43% <64.00%> (+0.59%)	⬆️
eest-develop-gmp	14.66% <0.00%> (-0.02%)	⬇️
eest-legacy	10.26% <72.00%> (+0.15%)	⬆️
eest-legacy-silkpre	16.20% <0.00%> (-0.02%)	⬇️
evmone-unittests	81.18% <12.00%> (-0.06%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
core	92.76% <ø> (+0.05%)	⬆️
tooling	84.38% <72.00%> (-0.31%)	⬇️
tests	81.42% <ø> (ø)

Files with missing lines	Coverage Δ
test/blockchaintest/blockchaintest_loader.cpp	95.23% <100.00%> (+0.04%)	⬆️
test/state/block.hpp	100.00% <ø> (ø)
test/blockchaintest/blockchaintest_runner.cpp	76.03% <70.83%> (-1.41%)	⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[gumb0]

I'm fine with this being taken over. Don't remember what exactly I wanted to add here. Supposedly some blockchain tests should be enabled as a result of the fixes (maybe bcInvalidHeaderTest.*), and maybe not everything is fixed yet. Try to run blockchain tests without filters to figure out.

[pdobacz]

bcInvalidHeaderTest

Thank you! Fully reenabling these tests causes a cascade of issues, and the requirement to handle ommers in 100%. For now I need the difficulty part, if there's capacity I'll circle back to it later.