Fix version check for nbclassic #1643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

yacchin1205 wants to merge 1 commit into ipython-contrib:master from NII-cloud-operation:fix/nbclassic

Contributor

yacchin1205 commented Jun 3, 2023

Fix #1642 - Fixed version handling to support the combination of jupyter_server and nbclassic.
The following points were considered.

On jupyter_server, sys_info does not have notebook_version
On nbclassic, Jupyter.version provides 1.x.x


          Fix version check for nbclassic

abadaee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet