Remove reliance on IPython's coloransi #924
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm nuking it in IPython 9.0 in favor of a lit of list of pairs of token and text, and having pygments/prompt_toolkit use formatting. In the and this module will likely not exists in IPython 9.0
Carreau
commented
Feb 7, 2025
Member
|
Makes sense, thanks for finding these downstream issues! |
|
ipython 9.0.0 was released yesterday, and the change in ipython/ipython#14692 has broken the latest ipyparallel release 9.0.0. Can we have a new ipyparallel release? In doing so, I guess you'll need to change the lower bound at Line 41 in d9670ba Thanks, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm nuking it in IPython 9.0 in favor of a lit of list of pairs of token and text, and having pygments/prompt_toolkit use formatting. In the and this module will likely not exists in IPython 9.0