Add health check#27
Open
jpneverwas wants to merge 2 commits into
Open
Conversation
Member
|
I think I'm going to leave this one unmerged for the moment, but I should really try and work out why this failure is happening. (It does happen on my irccat instances, but only once every 6 months or so, so it's a bit of a pain to debug.) Thanks for all your PRs and sorry for the slowness in getting them merged! |
Contributor
Author
|
Not at all. Happy to contribute.
|
|
@russss if it helps, I run irccat on a home server and I reliably get the "it's running, but nothing is happening" issue every time my home internet connection drops and reconnects. Might make it easier to reproduce? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I've also experienced a bit of downtime (likely) related to #21. The rather effective caveman workaround I've resorted to may be too crude for anyone's liking, so I present it here with all humility. Basically, this provides a tiny second binary to be built and included alongside the main one. Docker automatically uses this to gauge the health of the main process. Those not using capital "D" docker can either exec the command manually or hit an included HTTP endpoint that provides similar utility.
This all works in the dumbest way possible: by having an incoming
PONGhandler print a timestamp to a file whenever it runs, thereby providing an out-of-band heartbeat for any external monitor/supervisor to look for (two periods elapsing without an update means it's time to restart the daemon). This has saved me multiple times, but I completely understand if people find it too simplistic or just gross.Thanks.