WIP analysis python plumbing #496
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The analysis result do match for matmuls, but sympy is unable to prove equality between:
even with simplification. Short of finding the way to extract the common component from the piecewise generally, we may need some tweaking in reconstruction to automate the tests. |
ftynse
force-pushed
the
users/ftynse/python-connection
branch
from
65e948c to
1e1a4de
Compare
This mirrors the index symbol attribute and lets us differentiate induction variables used in indexing expressions from regular symbols with the same name without resorting to magic naming schemes in the C++ code. Since we are reusing affine expression parser that expects a bare keyword, we still have to resort to the magic naming scheme prefixing with `_Iter` in the textual format of the IR. Harden the verifier to complain about regular symbol names starting with an underscore and make them reserved. Signed-off-by: Alex Zinenko <[email protected]>
Signed-off-by: Alex Zinenko <[email protected]>
Signed-off-by: Alex Zinenko <[email protected]>
Signed-off-by: Alex Zinenko <[email protected]>
ftynse
force-pushed
the
users/ftynse/python-connection
branch
from
1e1a4de to
6a6279d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needs to be augmented with tests and sliced properly, but feel free to review with that in mind