Fix ReadOpLoweringPattern to handle vector results after PropagateEle… #632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mentsPerThread The ReadOpLoweringPattern was assuming ReadOp results are always WaveTensorType that need conversion to VectorType. However, after PropagateElementsPerThread pass runs, ReadOp results are already converted to VectorType. This fix detects if the result is already a vector type and uses it directly, otherwise falls back to the original type conversion logic. Signed-off-by: tyb0807 <[email protected]>
tyb0807
force-pushed
the
fix-readop-vector-handling
branch
from
9d62cf6 to
3a96ddc
Compare
ftynse
approved these changes
Dec 23, 2025
Contributor
ftynse
left a comment
ftynse
left a comment
There was a problem hiding this comment.
Yeah, maybe we should just reject non-vector types here and expect the propagation to have run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…mentsPerThread
The ReadOpLoweringPattern was assuming ReadOp results are always WaveTensorType that need conversion to VectorType. However, after PropagateElementsPerThread pass runs, ReadOp results are already converted to VectorType.
This fix detects if the result is already a vector type and uses it directly, otherwise falls back to the original type conversion logic.