Skip to content

[#2298] Add changelog and option for debug build (main) - #2302

Merged
alanking merged 2 commits into
irods:mainfrom
korydraughn:2298.m
Jun 22, 2026
Merged

[#2298] Add changelog and option for debug build (main)#2302
alanking merged 2 commits into
irods:mainfrom
korydraughn:2298.m

Conversation

@korydraughn

@korydraughn korydraughn commented Jun 19, 2026

Copy link
Copy Markdown
Contributor
  • Confirm --debug_build works

Comment thread CHANGELOG.md Outdated
Comment thread CHANGELOG.md

@alanking alanking left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the version bump?

@korydraughn korydraughn changed the title [#2298] Add changelog, bump version (main) [#2298] Add changelog and option for debug build (main) Jun 19, 2026
@korydraughn

Copy link
Copy Markdown
Contributor Author

Oh right. The version bump already happened.

@alanking alanking left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# on @JustinKyleJames' approval

@JustinKyleJames

Copy link
Copy Markdown
Contributor

I will test the debug build part.

@korydraughn

Copy link
Copy Markdown
Contributor Author

--debug_build worked for ub24.

  • The file command reports with debug_info, not stripped
  • The CMakeCache.txt file contains CMAKE_BUILD_TYPE:STRING=Debug

Rerunning the build without --debug_build produces a release build as expected.

  • The file command output does not contain with debug_info
  • The CMakeCache.txt file contains CMAKE_BUILD_TYPE:STRING=Release

Waiting for @JustinKyleJames' confirmation of debug info.

@JustinKyleJames

Copy link
Copy Markdown
Contributor

Without --debug_build:

$ file libs3.so 
libs3.so: ELF 64-bit LSB shared object, x86-64, version 1 (SYSV), dynamically linked, not stripped

With --debug_build:

$ file libs3.so 
libs3.so: ELF 64-bit LSB shared object, x86-64, version 1 (SYSV), dynamically linked, with debug_info, not stripped

Comment thread CHANGELOG.md Outdated

@alanking alanking left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squash

@korydraughn

Copy link
Copy Markdown
Contributor Author

Squashed.

@alanking alanking left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# it

@korydraughn

Copy link
Copy Markdown
Contributor Author

Added pounds.

@alanking
alanking merged commit 5f206ae into irods:main Jun 22, 2026
6 of 18 checks passed
@korydraughn
korydraughn deleted the 2298.m branch June 22, 2026 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants