-
Notifications
You must be signed in to change notification settings - Fork 74
[#726,#774] Migrate to pyproject.toml and add GH action for ruff
#790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
pyproject.toml and add GH action for ruff
alanking
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice
|
Converting to draft, |
|
Ready for review. |
|
Looks like Ruff has an opinion |
It does. Given the teensy size of the file in question, I'm going to ignore this one. But it's a good example of what log output from ruff will look like, which @d-w-moore was asking about this morning. |
d-w-moore
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. I did cut and paste the unified diff and it worked via patch.
|
Let's go ahead and resolve the ruff-check. Get that free green. It can happen during the squash. If there's nothing else left to do, squash it. |
|
squashed |
|
Not sure if it was missed in the last time, or the GHA workflow picked up something new this time, but there's one more thing in the Ruff report. It could be instructive for future PRs to address it, and then we can get this in. |
|
Agreed. Let's remove the empty line it's reporting about and watch it turn green. |
|
Should be good now |
alanking
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# it
|
#'d |
Addresses #726
Addresses #774