DRAFT: variations in eval runner#779
Draft
alexmillane wants to merge 70 commits into
Draft
Conversation
Introduce the variation framework: a VariationBase with build-time and run-time flavors, a SamplerBase abstraction with uniform and categorical samplers, and two concrete variations -- HDR dome-light image selection (build-time) and camera extrinsic decalibration (run-time). Variations attach to any Asset (scene objects or embodiments) and are collected by ArenaEnvBuilder, which applies build-time variations before scene composition and folds run-time variations into the event manager cfg. All variations default to disabled so existing envs are unchanged. The variations package exposes its API lazily (PEP 562 __getattr__): camera_decalibration pulls in torch and isaaclab.sensors, and importing that pair before the SimulationApp launches corrupts USD's Python bindings. Lazy exports keep importing the package -- or its lightweight base/sampler submodules -- safe at module-load time (e.g. pytest collection). Signed-off-by: alex <amillane@nvidia.com>
- Rename camera_decalibration.py -> camera_decalibration_variation.py - Drop package-level re-exports; import concrete classes from submodules - Remove sampler/variation listener plumbing (deferred to a follow-up MR) - Hoist a compulsory sampler_cfg field onto VariationBaseCfg and rename the per-variation sampler field to sampler_cfg - Replace UniformSampler.event_shape with an abstract SamplerBase.shape_per_sample - Drop the camera variation's unused mode field (all variations fire on reset) - Move attribute docs onto each member and trim docstrings to one line Signed-off-by: alex <amillane@nvidia.com>
Agents drove the container with bare `docker exec` (root), while users attach via run_docker.sh as their host user (su $(id -un)). Root-run commands left root-owned files in shared caches (/tmp/Assets, ~/.config) that the host user could not read, breaking their later interactive runs. Update AGENTS.md and the dev-container/run-tests skills to route every in-container command through `su $(id -un) -c`, mirroring run_docker.sh. Signed-off-by: alex <amillane@nvidia.com>
…ariations_in_eval_runner
…re/variations_in_eval_runner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Connects the
eval_runner.pyto the variations.Detailed description
Job/jsonto add a field for variations.ArenaEnvBuilderfor building.droid_pnp_variations_config.jsonthat demonstrates how to use this feature and added it to the (placeholder) docs.