Skip to content

Removes kit dependency at runtime for asset configuration #3756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+9 −3
Open

Removes kit dependency at runtime for asset configuration #3756

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7dd771e
adds type checking guard for assets
nv-rgresia Oct 17, 2025
0580327
Merge branch 'main' into type-checking-cfg-imports
nv-rgresia Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CONTRIBUTORS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,7 @@ Guidelines for modifications:
* René Zurbrügg
* Ritvik Singh
* Rosario Scalise
* Ryan Gresia
* Ryley McCarroll
* Shafeef Omar
* Shaoshu Su
Expand Down
2 changes: 1 addition & 1 deletion source/isaaclab/isaaclab/managers/action_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,13 @@

import omni.kit.app

from isaaclab.assets import AssetBase
from isaaclab.envs.utils.io_descriptors import GenericActionIODescriptor

from .manager_base import ManagerBase, ManagerTermBase
from .manager_term_cfg import ActionTermCfg

if TYPE_CHECKING:
from isaaclab.assets import AssetBase
from isaaclab.envs import ManagerBasedEnv


Expand Down
9 changes: 7 additions & 2 deletions source/isaaclab/isaaclab/managers/scene_entity_cfg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,15 @@

"""Configuration terms for different managers."""

from __future__ import annotations

from dataclasses import MISSING
from typing import TYPE_CHECKING

if TYPE_CHECKING:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you move this logic to the end of the imports?

from isaaclab.assets import Articulation, RigidObject, RigidObjectCollection
from isaaclab.scene import InteractiveScene

from isaaclab.assets import Articulation, RigidObject, RigidObjectCollection
from isaaclab.scene import InteractiveScene
from isaaclab.utils import configclass


Expand Down
Loading