Skip to content

Fixes for missing desktop icon when running scripts on DGX Spark #3804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 23, 2025
Merged

Fixes for missing desktop icon when running scripts on DGX Spark #3804

merged 2 commits into from
Oct 23, 2025

Conversation

@matthewtrepte
Copy link
Contributor

Description

Fix for missing desktop icon when running scripts on DGX Spark

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Screenshots

Please attach before and after screenshots of the change if applicable.

Checklist

  • I have read and understood the contribution guidelines
  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@greptile-apps
Copy link

greptile-apps bot commented Oct 22, 2025

Skipped: This PR changes more files than the configured file change limit: (100)

@matthewtrepte matthewtrepte changed the base branch from main to release/2.3.0 October 22, 2025 23:37
@github-actions github-actions bot added bug Something isn't working infrastructure labels Oct 22, 2025
@matthewtrepte matthewtrepte force-pushed the mtrepte/spark_fix_missing_icon branch from 1de0ad6 to aa3692b Compare October 22, 2025 23:40
@kellyguo11 kellyguo11 changed the title Fix for missing desktop icon when running scripts on DGX Spark Fixes for missing desktop icon when running scripts on DGX Spark Oct 23, 2025
@kellyguo11 kellyguo11 merged commit 1433f8d into isaac-sim:release/2.3.0 Oct 23, 2025
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ooctipus ooctipus ooctipus approved these changes

@hhansen-bdai hhansen-bdai Awaiting requested review from hhansen-bdai hhansen-bdai is a code owner

@Mayankm96 Mayankm96 Awaiting requested review from Mayankm96 Mayankm96 is a code owner

@kellyguo11 kellyguo11 Awaiting requested review from kellyguo11 kellyguo11 is a code owner

@jtigue-bdai jtigue-bdai Awaiting requested review from jtigue-bdai

@pascal-roth pascal-roth Awaiting requested review from pascal-roth

@Toni-SM Toni-SM Awaiting requested review from Toni-SM

@ClemensSchwarke ClemensSchwarke Awaiting requested review from ClemensSchwarke

Assignees

No one assigned

Labels

bug Something isn't working infrastructure

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@matthewtrepte @ooctipus @kellyguo11