-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Feature/3438 uv windows support #4007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Francisco Beltrao <[email protected]>
Signed-off-by: Francisco Beltrao <[email protected]>
Greptile OverviewGreptile SummaryThis PR successfully adds UV package manager support to the Windows batch script ( Key Changes:
Implementation Quality: Confidence Score: 4/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant User
participant isaaclab.bat
participant UV
participant Python
User->>isaaclab.bat: Execute with -u/--uv flag
isaaclab.bat->>isaaclab.bat: Check if UV installed
alt UV not found
isaaclab.bat-->>User: Error: UV not installed
end
isaaclab.bat->>isaaclab.bat: Check _isaac_sim symlink
alt Missing symlink & no pip install
isaaclab.bat-->>User: Warning message
end
isaaclab.bat->>UV: Create environment (uv venv --clear)
UV-->>isaaclab.bat: Environment created
isaaclab.bat->>isaaclab.bat: Verify activate.bat exists
alt Activation script missing
isaaclab.bat-->>User: Error: Failed to create activation script
end
isaaclab.bat->>isaaclab.bat: Append ISAACLAB_PATH to activate.bat
isaaclab.bat->>isaaclab.bat: Append doskey alias to activate.bat
isaaclab.bat->>isaaclab.bat: Append RESOURCE_NAME to activate.bat
isaaclab.bat->>isaaclab.bat: Call extract_isaacsim_path
alt Isaac Sim path exists
isaaclab.bat->>isaaclab.bat: Append Isaac Sim env vars to activate.bat
end
isaaclab.bat-->>User: Success message with activation instructions
Note over User,Python: When installing packages
User->>isaaclab.bat: Execute with -i flag
isaaclab.bat->>isaaclab.bat: Call extract_pip_command
alt UV environment detected
isaaclab.bat->>isaaclab.bat: Check VIRTUAL_ENV/pyvenv.cfg for "uv"
isaaclab.bat->>UV: Use "uv pip install"
else Standard environment
isaaclab.bat->>Python: Use "python -m pip install"
end
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 files reviewed, no comments
Description
Adds
uvsupport to the Windows batch scriptisaaclab.batto match the functionality already available in the bash versionisaaclab.sh.All changes are in
isaaclab.batfile:extract_python_exe: Added detection for VIRTUAL_ENV environment variable to support uv virtual environmentsextract_pip_command: Detects uv environments and returns appropriate pip command (uv pip install vs python -m pip install)extract_pip_uninstall_command: Similar detection logic for uninstall operationssetup_uv_env: Creates and configures uv environments with Isaac Lab settings-u/--uvarguments: Create uv environments with optional name parameter (defaults to "env_isaaclab")Fixes #3438
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there