Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alphabetical order YAML script for Istio org members #1107

Closed
wants to merge 2 commits into from

Conversation

ronitblenz
Copy link

I want to join the Istio org!

Resolves Issue #1092

Approach 👍

I have made a directory called members, where you can add your name randomly (so that if somebody messes up with the already existing order, it would not affect the main members.yaml file). Now the script sorts the YAML and makes a copy of the tempname.yaml to generate updated members.yaml.

Screenshot 2023-06-30 at 1 27 53 PM

@ronitblenz ronitblenz requested a review from a team as a code owner June 30, 2023 08:50
@istio-testing istio-testing added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs-ok-to-test labels Jun 30, 2023
@istio-testing
Copy link
Contributor

Hi @ronitblenz. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To add yourself as a member, please send a different PR.

@ericvn
Copy link
Contributor

ericvn commented Jul 3, 2023

Can we not check in the temp_name.yaml and only generate it as needed to do the sort?

@howardjohn howardjohn added the do-not-merge Block automatic merging of a PR. label Jul 3, 2023
@istio-testing
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ronitblenz
Copy link
Author

Ok let me make the required changes.

@craigbox
Copy link
Contributor

Hi Ronit,

Thanks for your contribution. I'm going to close this PR as it has sat here for over 6 months. If you're interested in revisiting this, I suggest you join the Istio Slack and check in with Eric or John in #contributors as to how you should change your code to best achieve this goal.

Good luck as you ramp up your contributions to open source.

@craigbox craigbox closed this Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge Block automatic merging of a PR. needs-ok-to-test needs-rebase size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants