-
Notifications
You must be signed in to change notification settings - Fork 577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alphabetical order YAML script for Istio org members #1107
Conversation
Hi @ronitblenz. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To add yourself as a member, please send a different PR.
Can we not check in the temp_name.yaml and only generate it as needed to do the sort? |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Ok let me make the required changes. |
Hi Ronit, Thanks for your contribution. I'm going to close this PR as it has sat here for over 6 months. If you're interested in revisiting this, I suggest you join the Istio Slack and check in with Eric or John in #contributors as to how you should change your code to best achieve this goal. Good luck as you ramp up your contributions to open source. |
I want to join the Istio org!
Resolves Issue #1092
Approach 👍
I have made a directory called members, where you can add your name randomly (so that if somebody messes up with the already existing order, it would not affect the main members.yaml file). Now the script sorts the YAML and makes a copy of the
tempname.yaml
to generate updatedmembers.yaml
.